lfit / releng-reusable-workflows

Reusuable workflows developed by LF Release Engineering
Apache License 2.0
1 stars 9 forks source link

gradle-build action contains a hard-wired Java "distribution" value #191

Open ModeSevenIndustrialSolutions opened 7 hours ago

ModeSevenIndustrialSolutions commented 7 hours ago

I think this step might need some attention:

    - name: Setup JDK
      id: setup-jdk
      uses: actions/setup-java@v3
      with:
        java-version: ${{ inputs.jdk-version }}
        distribution: "temurin"

Distribution is required, but could have multiple values, as per the documentation: https://github.com/actions/setup-java?tab=readme-ov-file#supported-distributions

Might be better to set this in an optional input, with "temurin" as default value?