search

lfmatosm / embedded-topic-model

A package to run embedded topic modelling with ETM. Adapted from the original at: https://github.com/adjidieng/ETM
MIT License
85 stars 8 forks source link

Fixed several inconsistencies and added choice of GPU for Mac users. #12

Closed d-jiao closed 1 year ago

d-jiao commented 1 year ago

Hi Luiz Matos,

Thank you for the great work on implementing ETM! I'm using this model in one of my projects and realized some codes might be outdated. Thus, I made several updates and also added the choice of GPU for Mac users.

I'm using Python 3.10.12, and torch==2.1.0, gensim==4.2.0.

Hopefully, this will be helpful.

Best, Dian

lfmatosm commented 1 year ago

Hi @d-jiao, first of all, thanks for your work and the report! This is surely helpful. I plan on adding a CONTRIBUTING.md file soon so anyone can easily contribute.

I left a comment on a duplicate line of code. However, I can solve that too :)

About gensim and torch versions, did you had any problem whatsoever with the library by using these updated versions? I plan an update to the package soon and if you have encountered any difficulties regarding this, I should take notice.

Thanks, Luiz

d-jiao commented 1 year ago

Hi @lffloyd, Currently, I haven't encountered any version issues with Gensim and torch.

lfmatosm commented 12 months ago

@d-jiao thanks for the response. I've released version 1.2.X of the package a few days ago including your code and upgrading the dependencies.