React & Redux group project: set up your Kanban board

mustabbas commented 3 years ago

rockets-missions projects We are 2 people in this project

Lameck1 commented 3 years ago

Hi, @mustabbas & @lfmnovaes,

You've done well implementing your Kanban board 👏🏼.

Highlights:

You've properly assigned yourselves tasks ✔️
Task distribution is fair. The sums of points from your tasks are equal ✔️

We however still have four tasks missing on the board that we need to add.

Required Changes ♻️

[ ] The total number of tasks from this template is 24, removing 7 for Team3, we'll have 17 left. Your own board has only 13 tasks instead of 17. Please cross-check and make the necessary adjustments. Missing tasks:
- [1pt] Create app and install basic dependencies - Setup (group task)
- [1pt] Create website header with empty nav - Setup (group task)
- [1pt] Create empty My profile - Setup (group task)
- [1pt] Create basic structure for Rockets - Setup

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

lfmnovaes commented 3 years ago

Hi @Lameck1 , thanks for the review and keen eye for the missing issues. We did import those issues through the .sh script and I don't know why didn't add these 4. I just tried again and still is not adding these 4 issues from the template, can you check/report about it too? Had to manually add these 4.

Lameck1 commented 3 years ago

Hi, @lfmnovaes, thanks for the info, we'll look into it.

omar-labana commented 3 years ago

Hi @lfmnovaes and @mustabbas ,

Changes by the previous reviewer are all fulfilled.👏 Your project is complete! There is nothing else to say other than... it's time to start your project 👏 Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

lfmnovaes / rockets-missions