search

lfoppiano / streamlit-pdf-viewer

Streamlit PDF viewer
https://structure-vision.streamlit.app/
Apache License 2.0
62 stars 3 forks source link

Add Type Validation for `width` and `height` Parameters in `pdf_viewer` Function #18

Closed t29mato closed 5 months ago

t29mato commented 5 months ago

Currently, the pdf_viewer function accepts width and height parameters, which are expected to be integers or None. However, there's no explicit type checking in place.

lfoppiano commented 5 months ago

Why the width has a default value of 700?

t29mato commented 5 months ago

There is no exact reason. I have thought that 30px is too narrow and 2000px is too wide. We can change these values to more reasonable numbers. I don't know which number is the bese, though. Do you have any idea?

lfoppiano commented 5 months ago

No, if we don't pass any default value, what will happen?