lfoppiano / supercon2

Staging-area for automatically collected experimental data for the SuperCon database with a curation interface with enhanced-document viewer and curation-ready interface
https://supercon2.readthedocs.io
4 stars 0 forks source link

Error message appearing when we press "remove" button #151

Closed kensei-te closed 1 year ago

kensei-te commented 1 year ago

Following error message appears(attached figure), even after specifying corresponding error type. Therefore I cannot remove them. Right now all I could do is to mark as invalid (thumb-down button) and put error-type by edit.

What to do?

スクリーンショット 2023-02-01 12 41 55
lfoppiano commented 1 year ago

Thanks! We found the problem. Sorry about that. Should be fixed before the end of the week.

lfoppiano commented 1 year ago

@kensei-te we fixed the problem and re-deployed. Could you try again and let me know if it works?

kensei-te commented 1 year ago

It worked. Thank you for your quick fixing.

BTW, is it possible to keep showing removed one as status "removed"? hmmm, maybe in other words, putting a tag "invalid" might be enough for curation. How do you think?

lfoppiano commented 1 year ago

@kensei-te I'm not sure I understand the question. When a record is removed, it is not showed (but it's still in the database). What do you want to achieve exactly?

lfoppiano commented 1 year ago

I close this issue. Perhaps is better to discuss the last comments in a new issue so that we don't mix up two different topics

kensei-te commented 1 year ago

@kensei-te we fixed the problem and re-deployed. Could you try again and let me know if it works?

Hmmm, as of 9th Feb, the similar error again appears. Could you check this?

スクリーンショット 2023-02-09 9 44 51
lfoppiano commented 1 year ago

@kensei-te sorry, the issue was not fully solved. It should be now.

You could check on the same database, just refresh the page and try to remove the record.

kensei-te commented 1 year ago

OK, I could remove now.

Just let me inform possible minor bug that happened just now. When I press remove, the order of error types appearing in the pop-up has changed. Somehow "composition resolution" has come to the top

lfoppiano commented 1 year ago

Yes, that's normal. Now such information it's fetched from the API, so it's the same when you remove from the database page.

kensei-te commented 1 year ago

Yes, that's normal. Now such information it's fetched from the API, so it's the same when you remove from the database page.

I see. I thought it was in order of "Error-types" appearing the paper (start from "from tables", "extraction",,,,,), but anyway whichever is fine.