search

lfoppiano / supercon2

Staging-area for automatically collected experimental data for the SuperCon database with a curation interface with enhanced-document viewer and curation-ready interface
https://supercon2.readthedocs.io
4 stars 0 forks source link

Document cannot be edited #172

Closed lfoppiano closed 1 year ago

lfoppiano commented 1 year ago

This document cannot be edited, it seems an error occurs in the JS part:

http://falcon.nims.go.jp/supercon/correction/document/7b3d9a7e09

"cannot be edited": when trying to edit any record the "Save" button is not clickable

t29mato commented 1 year ago

If the DOI is not entered, the save button cannot be pressed. I think I wanted the field to be required when creating a new record from scratch. It should have at least shown an error message. Is it okay to modify that the DOI is no longer a required item?

lfoppiano commented 1 year ago

You can get the data from the database supercon_correction on falcon

t29mato commented 1 year ago

ok, but I think you are replying to https://github.com/lfoppiano/supercon2/issues/155

lfoppiano commented 1 year ago

Yeah

t29mato commented 1 year ago

I'm wondering why non-DOI records exist

lfoppiano commented 1 year ago

Since we are processing the whole Arxiv archive, some document might come before the DOI era... so it's possible that the DOI is not present

t29mato commented 1 year ago

I see

t29mato commented 1 year ago

https://github.com/lfoppiano/supercon2/blob/main/supercon2/service.py#L313-L314 This is ... 😎