search

lfos / calcurse

A text-based calendar and scheduling application
https://calcurse.org
BSD 2-Clause "Simplified" License
1k stars 96 forks source link

"sidebar" configuration submenu is empty #302

Open Kabouik opened 4 years ago

Kabouik commented 4 years ago

Bug description. Provide a clear and concise description of what the bug is. Press C to enter configuration mode, then s for sidebar. There is nothing to configure there, and no command can be entered either.

Expected behavior. Unless I don't understand it, since the sidebar submenu exists, it is expected that some interaction would be possible inside it. For instance, I saw on culot.org that there is a side-bar_width option, but it doesn't work when set in the configuration file, so I was hoping I could set it there.

lfos commented 4 years ago

You can see in the status bar on the bottom that the j and k keys can be used to resize the status bar. Is that not obvious enough?

Kabouik commented 4 years ago

It is visible enough but it has no effect on my installation, so I was assuming that something else was missing in the menu and j and k would be used to cycle through other options. Turns out the problem is different and I need to investigate why j and k do not do anything on my instance.

On 2020-07-21 12:53 Lukas Fleischer notifications@github.com wrote:

You can see in the status bar on the bottom that the j and k keys can be used to resize the status bar. Is that not obvious enough?

--
You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/lfos/calcurse/issues/302#issuecomment-661785079

lfos commented 4 years ago

Did you try to repeat the key strokes multiple times (i.e. push and hold j for a while, then push and hold k for a while)?

Kabouik commented 4 years ago

I tried to tap multiple times, but not holding the key. It seems only holding the key (to trigger automatic key repeat) has an effect, thank you. Maybe this should be written, or alternatively make j/k alter the width of the sidebar on individual key presses?

I don't think it's obvious that the keys must be held (or tapped very fast, since this triggers key repeat too), since all other settings of the configuration have an immediate effect when pressing a key, and here the changes appear only after ~1 second doing a action other than a simple key press due to the delay before key repeat.

lfos commented 4 years ago

After you see the sidebar width changing, a single key press should work too. The reason is that your sidebar was probably configured to be very small, much smaller than it can be on screen, and it takes some time to increase it past the minumum display width. I agree that this should be improved somehow though.

Kabouik commented 4 years ago

That makes sense, thanks! Then maybe force limits to the minimal and maximal width and avoid users to overshoot in one direction and then haveto compensate in the other?

On 2020-07-22 13:27 Lukas Fleischer notifications@github.com wrote:

After you see the sidebar width changing, a single key press should work too. The reason is that your sidebar was probably configured to be very small, much smaller than it can be on screen, and it takes some time to increase it past the minumum display width. I agree that this should be improved somehow though.

--
You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/lfos/calcurse/issues/302#issuecomment-66239991 5

lfos commented 4 years ago

The problem is that the sidebar width is configured as a ratio of the total window size. There's no reasonable lower limit for that since even a percentage of 1% might make sense for extremely wide screens. I agree that we may want to reconsider and improve this; let's leave this bug open to keep track of the status.