lfph / lfph.io

๐Ÿ•ธ๏ธ๐Ÿ‘๏ธThe public-facing lfph.io website
MIT License
5 stars 4 forks source link

FAQ sidebar can't scroll separately #76

Closed jennydove closed 4 years ago

jennydove commented 4 years ago

Steps to reproduce on FAQ page:

  1. Have the window height be less than the length of the full page
  2. Be curious about what the bottom-most question is
  3. Try to scroll the navigation bar down to the bottom question
  4. Instead find yourself needing to scroll the entire FAQ content

Potential solutions:

cjyabraham commented 4 years ago

This page shows the second solution you suggest. You'll need to probably reduce the height of your browser to see how the left-pane scrolls independent of the right. Perhaps we may be able to implement that.

Here's another possible solution: I've removed the "Table of contents" at the top and reduced the length of some of the questions. The full list now fits on my 15" laptop screen. Any thoughts?

Screen Shot 2020-08-04 at 10 44 16 AM

And I've opened a related issue.

jennydove commented 4 years ago

I'm on a 13" so I don't need to resize much ๐Ÿ˜…. The two-pane scroll does the trick - the only amendment I would have is it needs a little more padding at the bottom because the last question gets a bit cut off:

[image: image.png]

On Mon, Aug 3, 2020 at 8:55 PM Chris Abraham notifications@github.com wrote:

This page https://events.linuxfoundation.org/kubecon-cloudnativecon-europe/program/colocated-events/ shows the second solution you suggest. You'll need to probably reduce the height of your browser to see how the left-pane scrolls independent of the right. Perhaps we may be able to implement that.

Here's another possible solution: I've removed the "Table of contents" at the top and reduced the length of some of the questions. The full list now fits on my 15" laptop screen. Any thoughts? [image: Screen Shot 2020-08-04 at 10 44 16 AM] https://user-images.githubusercontent.com/463160/89247406-da2eb800-d63f-11ea-8be3-a562c84d737a.png

And I've opened a related issue https://github.com/lfph/lfph.io/issues/77.

โ€” You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lfph/lfph.io/issues/76#issuecomment-668350883, or unsubscribe https://github.com/notifications/unsubscribe-auth/APBTCLASQHZMJTOHQT2Y4R3R652DXANCNFSM4PT4UEGQ .

thetwopct commented 4 years ago

I've worked on that today along with a few other scroll/hash issues https://github.com/lfph/lfph.io/pull/78

thetwopct commented 4 years ago

Test of new solution https://pr-78-lfph.pantheonsite.io/join/faq/

jennydove commented 4 years ago

Looks awesome. My favorite is "what the FAQ"

cjyabraham commented 4 years ago

What do you think of including a shadow once the sidebar is scrolled down to suggest it can be scrolled up, as done here:

Screen Shot 2020-08-05 at 4 19 13 PM
cjyabraham commented 4 years ago

@jennydove James has fixed this and I've just deployed it. Would you play around with the FAQ again and reopen the issue if not ok please?