search

lfranchi / libechonest

A C++/Qt wrapper around the wonderful echo nest api
Other
10 stars 5 forks source link

add SongType Support #1

Closed Horrendus closed 11 years ago

Horrendus commented 11 years ago

add Support for "SongType" API of echonest, see: http://blog.echonest.com/post/36215424761/we-are-doing-it-live & http://blog.echonest.com/post/35845347430/christmas-comes-early-to-the-echo-nest

Test cases are pretty useless, were more "test programs" for me ... tell me if I should delete them (and make no tests) or do some better ones ;)

lfranchi commented 11 years ago

Looks like most of SongTypeTest.cpp is copy&pasted from SongTest.cpp. Can you just add t he song type test to teh existing SongTest.cpp, no need for another test file

Horrendus commented 11 years ago

I made the tests usefull and removed SongTypeTest.cpp & SongTypeTest.h

lfranchi commented 11 years ago

Looks good! Thanks