search

lfreist / hwinfo

cross platform C++ library for hardware information (CPU, RAM, GPU, ...)
MIT License
477 stars 85 forks source link

fix build on macOS #100

Closed Shieldine closed 3 months ago

Shieldine commented 3 months ago

This PR fixes the failing build on macOS. It seems to have been caused by removing the explicit setting of a cpp standard in the main CMakeLists.txt

It's now set to 20 as it was in previous commits

lfreist commented 3 months ago

@Shieldine can you elaborate, why C++20 is needed for macOS? hwinfo builds with C++11 on Windows and Linux... Or is it just that the used standard must be set?

Shieldine commented 3 months ago

@lfreist it's just that a standard must be set or macOS will take something below 11 and thus fail to build. Looking at previous commits, c++20 was defined. If 11 is enough, i can gladly change to 11. We just need something that is 11 or above

lfreist commented 3 months ago

Thank you! Yes, please set it to 11 then. The plan is, that the first release is C++11 and later releases introduce more modern features. I want to make sure that a working version is available for C++11 compilers...

Shieldine commented 3 months ago

@lfreist Way ahead of you! :) C++11 already passed the pipeline, ready to merge