lfreist / hwinfo

cross platform C++ library for hardware information (CPU, RAM, GPU, ...)
MIT License
438 stars 76 forks source link

Added `Available Memory` module to Linux #22

Closed Ace-Krypton closed 1 year ago

Ace-Krypton commented 1 year ago

I only added Linux for now, I don't have windows laptop on me right now so I will add it later on

lfreist commented 1 year ago

Adding only Linux is fine, but please implement dummy methods for all platforms just returning a default value (-1 for integer types) so that all platforms can build (see github actions). Thanks for your contribution!

Ace-Krypton commented 1 year ago

I added dummy methods, if there is something else wrong sorry, I am not good at this kinda styling, just tried to help with something :)

lfreist commented 1 year ago

You just returned a string from a function that must return an integer. Please return -1 instead of "" and it is fine.

Thanks for your efforts!

Ace-Krypton commented 1 year ago

last one should be okay, anyways thanks, I will fill out those dummy methods too, in few weeks