Suggestion for Windows, CI, and CMake

luncliff commented 9 months ago

Hi @lfreist , appreciate your great work. I'm reviewing the internals before suggesting this project to https://github.com/microsoft/vcpkg

These are my ideas for future maintenance. Would you consider it?

Changes

GitHub Actions

Bump the actions/checkout's version
After Git checkout, fetch Git submodules

CMake

Mock https://cmake.org/cmake/help/latest/variable/PROJECT_IS_TOP_LEVEL.html in CMake 3.21+
- Replaces MAIN_PROJECT
New build options
- BUILD_TESTING
- BUILD_EXAMPLES
Support install target
- Install headers under ${prefix}/include
- Install libraries under ${prefix}/lib

Example

Return 0 for int main(...)

WMI(Windows Management Instrumentation)

In main branch, CI fails because SerialNumber is empty. Added nullptr check in several points.

lfreist commented 9 months ago

Hi, thank you for your valuable contribution. The changes indeed increase the quality of HWinfo!

What exactly are your suggestion for future maintenance?

luncliff commented 9 months ago

CMake updates. Package managers run install instead of relocating output libraries.

On Sat, Dec 2, 2023, 05:34 Leon Freist @.***> wrote:

Merged #68 https://github.com/lfreist/hwinfo/pull/68 into main.

— Reply to this email directly, view it on GitHub https://github.com/lfreist/hwinfo/pull/68#event-11126280912, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADLSYE64LDAIJCJFUIHGA63YHI5ORAVCNFSM6AAAAABADFSIFWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGEZDMMRYGA4TCMQ . You are receiving this because you authored the thread.Message ID: @.***>

lfreist commented 9 months ago

Yes, absolutely consider it. I'd like to have a first release version and this will be published using vcpkg

lfreist / hwinfo