Closed luncliff closed 9 months ago
Hi, thank you for your valuable contribution. The changes indeed increase the quality of HWinfo!
What exactly are your suggestion for future maintenance?
CMake updates. Package managers run install instead of relocating output libraries.
On Sat, Dec 2, 2023, 05:34 Leon Freist @.***> wrote:
Merged #68 https://github.com/lfreist/hwinfo/pull/68 into main.
— Reply to this email directly, view it on GitHub https://github.com/lfreist/hwinfo/pull/68#event-11126280912, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADLSYE64LDAIJCJFUIHGA63YHI5ORAVCNFSM6AAAAABADFSIFWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGEZDMMRYGA4TCMQ . You are receiving this because you authored the thread.Message ID: @.***>
Yes, absolutely consider it. I'd like to have a first release version and this will be published using vcpkg
Hi @lfreist , appreciate your great work. I'm reviewing the internals before suggesting this project to https://github.com/microsoft/vcpkg
These are my ideas for future maintenance. Would you consider it?
Changes
GitHub Actions
actions/checkout
's versionCMake
MAIN_PROJECT
option
sBUILD_TESTING
BUILD_EXAMPLES
install
target${prefix}/include
${prefix}/lib
Example
Return
0
forint main(...)
WMI(Windows Management Instrumentation)
In
main
branch, CI fails becauseSerialNumber
is empty. Addednullptr
check in several points.