Fix build on MacOS - Githubissues

lfreist / hwinfo

cross platform C++ library for hardware information (CPU, RAM, GPU, ...)

MIT License

433 stars 74 forks source link

Fix build on MacOS #85

Closed Shieldine closed 2 months ago

Shieldine commented 3 months ago

This PR fixes build errors on MacOS. Tested locally, the following info are displayed correctly:

OS: OS, version
CPU: physical cores and logical cores

Everything else still needs to be implemented/fixed

Shieldine commented 2 months ago

I can't really tell what's the issue. A local style check doesn't tell me anything's wrong. A local build also works without issues, however, my system uses xcode 15.4 (which seems to be newer than what the pipeline uses).

I let me IDE refactor the two files mentioned - hopefully, this will fix the style check. I'll see what I can do about the failing build in the pipeline

lfreist commented 2 months ago

I cannot reproduce the pipeline error either. I'll evaluate the pipeline build and accept the pull request.

Thank you for contributing!