search

lfurzewaddock / vscode-opn

Opens files in the default application for the file type set in the OS
MIT License
5 stars 2 forks source link

Add a context menu entry #2

Open hashhar opened 8 years ago

hashhar commented 8 years ago

See Microsoft/vscode#9213 for what I mean.

I even sent a PR but it seems such things are better suited in extensions. If you would like I can submit a PR to your extension too.

lfurzewaddock commented 8 years ago

@hashhar I would be happy to integrate new functionality as long as it doesn't upset the default behaviour (open active file in default app). Any other functionality should be on an opt in basis using the Workspace/User Settings JSON.

My extension is written in JavaScript ES5, but should be fairly easy to accommodate the JavaScript your TypeScript generates (ES5, rather then ES6/2015).

hashhar commented 8 years ago

@lfurzewaddock Okay. I'll try and get a PR ready within the week.

InDIOS commented 8 years ago

Hi, i has implemented this feature, just take a look to the screenshots below and tell me what do you think about it. If the answer is positive, i'll be happy to do the corresponding PR.

Editor Context Menu: editor-context

Explorer Context Menu explorer-context

lfurzewaddock commented 8 years ago

@InDIOS looks good :+1: Submit a pull request in JavaScript ES5 and I'll merge it. I'm away for a break, so no rush!