search

lgalfaso / angular-dynamic-locale

Module to be able to change the locale at an angularjs application
http://lgalfaso.github.io/angular-dynamic-locale/
MIT License
322 stars 75 forks source link

@type definition #113

Closed gerardolima closed 5 years ago

gerardolima commented 7 years ago

Hi, @lgalfaso, is there any Typescript definition file for tmhDynamicLocale?

lgalfaso commented 7 years ago

There is no Typescript definition, but a PR is welcome.

gerardolima commented 7 years ago

nice, I'm really short on time for this sprint, but I can do it soon

tYYGH commented 6 years ago

Hi! I see that the pull request has been merged (thanks! by the way). Would it be possible to release a version, so that this feature can be made available through a package.json file?

lgalfaso commented 6 years ago

Sure, will cut a new release in a few days

On Wed, Mar 7, 2018 at 9:25 AM tYYGH notifications@github.com wrote:

Hi! I see that the pull request has been merged (thanks! by the way). Would it be possible to release a version, so that this feature can be made available through a package.json file?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lgalfaso/angular-dynamic-locale/issues/113#issuecomment-371061001, or mute the thread https://github.com/notifications/unsubscribe-auth/AAX44pTZZv1fNwh5leCWVgmYu7mp4sz6ks5tb5mUgaJpZM4OCJWY .

lgalfaso commented 6 years ago

@tYYGH Had a slightly messy release cut as the automated script had some failures, but a new release is now live with the type information in package.json. Let me know if you have any issues.

lgalfaso commented 5 years ago

From the last comment, my understanding is that this issue is now solved.