search

lgalfaso / angular-dynamic-locale

Module to be able to change the locale at an angularjs application
http://lgalfaso.github.io/angular-dynamic-locale/
MIT License
322 stars 75 forks source link

Explicit annotation issue #119

Closed JackPapa0156 closed 6 years ago

JackPapa0156 commented 6 years ago

When boostraping angular v5 app using angular/upgrade module I've found following issue:

function(tmhDynamicLocaleProvider) is not using explicit annotation and cannot be invoked in strict mode.

After turning "strict-di" mode off everything is working: this.upgrade.bootstrap(document.body, ['my-app'], { strictDi: false });

It seems that it is not possible to work in "strict-di" mode with included angular-dynamic-locale.

lgalfaso commented 6 years ago

Hi, any chance that it is your app that is trying to inject tmhDynamicLocaleProvider and is not annotating that function?

On Thu, Apr 12, 2018 at 12:55 PM JackPapa0156 notifications@github.com wrote:

When boostraping angular v5 app using module I've found following issue:

function(tmhDynamicLocaleProvider) is not using explicit annotation and cannot be invoked in strict mode.

After turning "strict-di" mode off everything is working: this.upgrade.bootstrap(document.body, ['my-app'], { strictDi: false });

It seems that it is not possible to work in "strict-di" mode with included angular-dynamic-locale.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/lgalfaso/angular-dynamic-locale/issues/119, or mute the thread https://github.com/notifications/unsubscribe-auth/AAX44s3VnuuljuCDAX0EuWyhIvG_f5Rfks5tnzKhgaJpZM4TRkZk .

JackPapa0156 commented 6 years ago

You are f*cking right - I must have lost my head today. Great package, btw. Have a nice day! :)