search

lgalfaso / angular-dynamic-locale

Module to be able to change the locale at an angularjs application
http://lgalfaso.github.io/angular-dynamic-locale/
MIT License
322 stars 75 forks source link

Evaluate integration of Saucelabs in order to test cross-browser compatibility on commit #97

Open evilaliv3 opened 8 years ago

evilaliv3 commented 8 years ago

It would be valuable to integrate with Saucelabs in order to test cross-browser compatibility tests on commit.

As the library is using karma as testing framework my suggestion is to start implemeting them using karma-sauce-launcher.

This way it will be possiblle to automatically execute all the unit test on the selection of browsers targetted by the library (all) and know proactively where it is not working.

E.g.: https://github.com/globaleaks/GlobaLeaks screenshot from 2016-03-14 20 36 40

It would be also nice to start tracking the code quality of the project using for example CodeClimate and tracking also the code coverage by means of Coveralls + karma-coveralls

I've implemented the exact integration you need here: https://github.com/flowjs/flow.js/blob/master/karma.conf.js

An example of the output with all integrated is the following: https://github.com/globaleaks/GlobaLeaks

lgalfaso commented 8 years ago

PRs are welcome.

evilaliv3 commented 8 years ago

I know @lgalfaso thanks :) in the meantime i've annotated it if there is someone interested; i will try to do it in the spare time if we confirm that the component is needed for GlobaLeaks.

could you please give me an answer on: https://github.com/lgalfaso/angular-dynamic-locale/issues/93