lgallard / terraform-aws-cognito-user-pool

Terraform module to create Amazon Cognito User Pools, configure its attributes and resources such as app clients, domain, resource servers. Amazon Cognito User Pools provide a secure user directory that scales to hundreds of millions of users.
Apache License 2.0
89 stars 95 forks source link

require_verification_before_update #108

Closed lgallard closed 12 months ago

lgallard commented 1 year ago

Change @endrec implementation for a simpler definition of attributes_require_verification_before_update

Take into account attributes_require_verification_before_update must be the same as auto_verified_attributes, but instead of validating in code we can let Terraform validate it for us when running a plan / apply.

endrec commented 1 year ago

Take into account attributes_require_verification_before_update must be the same as auto_verified_attributes, but instead of validating in code we can let Terraform validate it for us when running a plan / apply.

attributes_require_verification_before_update must be a subset of auto_verified_attributes, not necessarily the same.

I was thinking about this simplification, but there must be a reason it is not this simple in the AWS terraform provider... I suspect they will add more settings to the user_attribute_update_settings map later.

lgallard commented 1 year ago

@endrec I need to rethink this. I would like to have an easy variable input probably with a map instead of having several inputs

Renaming this PR to require_verification_before_update

lgallard commented 12 months ago

@endrec closing for now. I will implement this in another PR in a future release