Missing an important output for the cognito domain

lgallard / terraform-aws-cognito-user-pool

Terraform module to create Amazon Cognito User Pools, configure its attributes and resources such as app clients, domain, resource servers. Amazon Cognito User Pools provide a secure user directory that scales to hundreds of millions of users.

Apache License 2.0

93 stars 99 forks source link

Missing an important output for the cognito domain #137

Closed catrielg closed 7 months ago

catrielg commented 7 months ago

The "aws_cognito_user_pool_domain" resource has an attribute named "cloudfront_distribution_zone_id". This is required if you want to create a route_53 record in Terraform or other SDK.

Suggested fix to add to the outputs.tf:

output "domain_cloudfront_distribution_zone_id" {
  description = "The ZoneID of the CloudFront distribution"
  value       = var.enabled ? join("", aws_cognito_user_pool_domain.domain.*.cloudfront_distribution_zone_id) : null
}

lgallard commented 7 months ago

@catrielg Add in 0.27.0 release.

Thanks for bring it up!