lgallard / terraform-aws-secrets-manager

Terraform module to create Amazon Secrets Manager resources.
Apache License 2.0
63 stars 50 forks source link

Missing "force_overwrite_replica_secret" #33

Closed btougeiro closed 1 year ago

btougeiro commented 1 year ago

The module doesn't offer the parameter: "force_overwrite_replica_secret".

File: https://github.com/lgallard/terraform-aws-secrets-manager/blob/master/main.tf

resource "aws_secretsmanager_secret" "sm" {
  for_each                = var.secrets
  name                    = lookup(each.value, "name_prefix", null) == null ? each.key : null
  name_prefix             = lookup(each.value, "name_prefix", null) != null ? lookup(each.value, "name_prefix") : null
  description             = lookup(each.value, "description", null)
  kms_key_id              = lookup(each.value, "kms_key_id", null)
  policy                  = lookup(each.value, "policy", null)
  recovery_window_in_days = lookup(each.value, "recovery_window_in_days", var.recovery_window_in_days)
  tags                    = merge(var.tags, lookup(each.value, "tags", null))
  dynamic "replica" {
    for_each = var.replica_regions
    content {
      region     = replica.key
      kms_key_id = replica.value
    }
  }
}

Please, add the following parameter.

resource "aws_secretsmanager_secret" "sm" {
  for_each                       = var.secrets
  name                           = lookup(each.value, "name_prefix", null) == null ? each.key : null
  name_prefix                    = lookup(each.value, "name_prefix", null) != null ? lookup(each.value, "name_prefix") : null
  description                    = lookup(each.value, "description", null)
  kms_key_id                     = lookup(each.value, "kms_key_id", null)
  policy                         = lookup(each.value, "policy", null)
  force_overwrite_replica_secret = lookup(each.value, "force_overwrite_replica_secret", false)
  recovery_window_in_days        = lookup(each.value, "recovery_window_in_days", var.recovery_window_in_days)
  tags                           = merge(var.tags, lookup(each.value, "tags", null))
  dynamic "replica" {
    for_each = var.replica_regions
    content {
      region     = replica.key
      kms_key_id = replica.value
    }
  }
}