search

lgatto / MSnbase

Base Classes and Functions for Mass Spectrometry and Proteomics
http://lgatto.github.io/MSnbase/
123 stars 50 forks source link

Only if con is character (filename) create a file connection. #506

Closed ricoderks closed 4 years ago

ricoderks commented 4 years ago

This should fixed issue #505.

codecov-io commented 4 years ago

Codecov Report

Merging #506 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #506   +/-   ##
=======================================
  Coverage   71.95%   71.96%           
=======================================
  Files          82       82           
  Lines        8281     8282    +1     
=======================================
+ Hits         5959     5960    +1     
  Misses       2322     2322
Impacted Files Coverage Δ
R/readWriteMgfData.R 87.50% <100.00%> (+0.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6d41fd1...ff1f431. Read the comment docs.

lgatto commented 4 years ago

Thank you. Merged, and will push to Bioc right away.