search

lgatto / MSnbase

Base Classes and Functions for Mass Spectrometry and Proteomics
http://lgatto.github.io/MSnbase/
123 stars 50 forks source link

Rename Chromatograms? #515

Closed jorainer closed 3 years ago

jorainer commented 4 years ago

Along the line of issue #514 , should we also rename the Chromatograms class? Maybe into ChromatogramMatrix because in fact it is organizing Chromatogram objects in a 2-dimentional matrix (and is extending matrix).

lgatto commented 4 years ago

What about MChromatograms - the M for matrix of chromatograms and the leading M to stick to the same pattern and in #514.

jorainer commented 4 years ago

I'm OK with that. After that I'll have to update also xcms - guess there are not many more packages using/extending directly classes from MSnbase.

lgatto commented 4 years ago

I don't think so. But the good thing is that we are early in the release cycle, so plenty of time to brake dependencies.