search

lgatto / MSnbase

Base Classes and Functions for Mass Spectrometry and Proteomics
http://lgatto.github.io/MSnbase/
123 stars 50 forks source link

refactor: add parameter ppm to combineSpectraMovingWindow #522

Closed jorainer closed 3 years ago

jorainer commented 3 years ago
lgatto commented 3 years ago

I assume this needs to be pushed upstreams to devel, or is it to RELEASE_3_10?

jorainer commented 3 years ago

Sorry for the late reply - this should go into the current Bioc devel (i.e. Bioc master branch). The fix for RELEASE_3_10 is in branch RELEASE_3_10

lgatto commented 3 years ago

Shouldn't this be RELEASE_3_11?

lgatto commented 3 years ago

I looks like everything is fine, just a version confusion, but waiting for you to confirm.

jorainer commented 3 years ago

I added the fix only for the master branch and also for the old RELEASE_3_10 because the user from issue #521 could not install a more recent R/Bioc version. The RELEASE_3_10 fix was for him to test if it was working at all.

lgatto commented 3 years ago

But I can't push to RELEASE_3_10 any more, this is the old Bioconductor release version. If there's a change to backport to release, it must be 3.11.

lgatto commented 3 years ago

So there isn't anything to push to any release branch.

lgatto commented 3 years ago

If ok for you, I would prefer to delete the RELEASE_3_* branches here on github, to avoid any confusion.

jorainer commented 3 years ago

Sure, no problem. Deleted the RELEASE_ branch