search

lgatto / MSnbase

Base Classes and Functions for Mass Spectrometry and Proteomics
http://lgatto.github.io/MSnbase/
123 stars 50 forks source link

-add TMT16plex #533

Closed MiguelCos closed 3 years ago

MiguelCos commented 3 years ago

Hello Prof Gatto,

I took the liberty to add the reporter ion objects for TMT16plex. I did this modification to run labelling efficiency tests using the proteoQC package and found it very useful. I am in the process of testing this modification in combination with the modified version that I needed to adapt from the proteoQC package.

This is the first time I do this kind of pull request so let me know if something is missing.

Best wishes, Miguel

lgatto commented 3 years ago

Thank you very much. There are several minor changes that are missing, which I'm addressing at the moment. I'll add these changes and merge your PR shortly.

lgatto commented 3 years ago

Fixed and merged now. Thank you for your contribution!

MiguelCos commented 3 years ago

It was a pleasure! Now I learned how to contribute to R packages :)