lgatto / MSnbase

Base Classes and Functions for Mass Spectrometry and Proteomics
http://lgatto.github.io/MSnbase/
123 stars 50 forks source link

refactor: move ProcessingStep to ProtGenerics #538

Closed jorainer closed 3 years ago

jorainer commented 3 years ago

Remove the ProcessingStep class and import it from ProtGenerics instead. Functionality is the same, but the version from ProtGenerics does no longer extend Versioned. I've checked if this creates any issues/problems with OnDiskMSnExp objects saved with older MSnbase version and it does not - all works fine.

lgatto commented 3 years ago

Ok to push to Bioc too?

jorainer commented 3 years ago

Yes please! And thanks!

lgatto commented 3 years ago

Done - with a version bump.