Add compareChromatograms method

lgatto / MSnbase

Base Classes and Functions for Mass Spectrometry and Proteomics

http://lgatto.github.io/MSnbase/

123 stars 50 forks source link

Closed jorainer closed 3 years ago

jorainer commented 3 years ago

Add a method compareChromatograms that allows to calculate a similarity score between two Chromatogram objects.

jorainer commented 3 years ago

No idea where the error from the unit test is coming from - seems from some other part of MSnbase

jorainer commented 3 years ago

Error fixed.

jorainer commented 3 years ago

OK, that's it. Now I won't add any more stuff to the PR. Looking forward to your review @lgatto

jorainer commented 3 years ago

I addressed your comments @sgibb - no idea why the CI fails, locally all tests were OK.

jorainer commented 3 years ago

the recent commit finished the transfer of the bin, compareChromatograms and compareSpectra methods to ProtGenerics.

lgatto commented 3 years ago

FYI - The GHA error seems to originate from MsCoreUtils.

lgatto commented 3 years ago

Pushed to Bioc.