fix: empty XIC plot if no data (issue #549)

lgatto / MSnbase

Base Classes and Functions for Mass Spectrometry and Proteomics

http://lgatto.github.io/MSnbase/

123 stars 50 forks source link

fix: empty XIC plot if no data (issue #549) #550

Closed jorainer closed 2 years ago

jorainer commented 2 years ago

This fixes issue #549: an empty plot is created if no data points are available for a file.

lgatto commented 2 years ago

@jorainer - this has apparently not been merged?

jorainer commented 2 years ago

Ah, no, that's true. Can you please merge and push to BioC (I think I have no access to the MSnbase BioC repo)?

lgatto commented 2 years ago

But some checks fail at the moment.

jorainer commented 2 years ago

It's a very strange error that I get in the centroiding vignette only when running either R CMD build MSnbase or R CMD check MSnbase. The error does not happen when rendering the vignette with rmarkdown alone.

jorainer commented 2 years ago

Forget my previous comment. It was a very stupid error. I called the splitByFile,MSnExp method in the wrong way. It was working on OnDiskMSnExp objects, but not on MSnExp objects. Now it should be fine.

lgatto commented 2 years ago

Pushed to Bioc.