Check error on Bioc servers

lgatto commented 2 years ago

The following happens both in release and devel

* checking tests ...
  Running ‘testthat.R’
 ERROR
Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
   5.       └─base::tryCatch(...)
   6.         └─base:::tryCatchList(expr, classes, parentenv, handlers)
   7.           └─base:::tryCatchOne(expr, names, parentenv, handlers[[1L]])
   8.             └─value[[3L]](cond)
  ── Error (test_methods-MChromatograms.R:621:5): .compare_chromatograms works ───
  Error in ``[<-`(`*tmp*`, j, i, value = m[i, j] <- compareChromatograms(x[[i]], 
      y[[j]], ALIGNFUN = ALIGNFUN, ALIGNFUNARGS = ALIGNFUNARGS, 
      FUN = FUN, FUNARGS = FUNARGS))`: subscript out of bounds
  Backtrace:
      █
   1. └─MSnbase:::.compare_chromatograms(list(chr1), list(chr2, chr3)) test_methods-MChromatograms.R:621:4

  [ FAIL 2 | WARN 1095 | SKIP 12 | PASS 2341 ]
  Error: Test failures
  Execution halted

@jorainer - could this be related to the recent commit #560 ?

jorainer commented 2 years ago

Could be - I would look into it.

jorainer commented 2 years ago

I've now also added the fix into the RELEASE_3_14 branch - I guess that the unit tests will again fail - but maybe you @lgatto can verify locally on your setup and then eventually push to BioC?

lgatto commented 2 years ago

Tested locally and pushed to Bioc release.

lgatto / MSnbase

Check error on Bioc servers #561