search

lgatto / MSnbase

Base Classes and Functions for Mass Spectrometry and Proteomics
http://lgatto.github.io/MSnbase/
127 stars 46 forks source link

Fix declarations of centroided/smoothed setters for OnDiskMSnExp objects #593

Closed hpages closed 1 year ago

hpages commented 1 year ago

Salut Laurent,

With current R-devel (R 4.4), trying to install MSnbase <= 2.25.2 fails with error messages complaining about the declarations of the centroided<- and smoothed<- methods for OnDiskMSnExp objects. The complain is:

arguments ('value') after '...' in the generic must appear in the method, in the same place at the end of the argument list

We've been notified by R-core that this breaks many CRAN packages that depend directly or indirectly on MSnbase when using the latest R devel.

This commit fixes the method delcarations so that they are compatible with R >= 4.4.

Best, H.

lgatto commented 1 year ago

Merci beacoup! And sorry for the hassle.

lgatto commented 1 year ago

I have pushed this to devel on Bioc too.

hpages commented 1 year ago

Merci Laurent !