search

lgatto / Pbase

Manipluating and exploring protein and proteomics data
8 stars 3 forks source link

Functions instead of generics #17

Closed lgatto closed 9 years ago

lgatto commented 9 years ago

In Pbase, there is a tendency of defining generics when a simple function would do. plot, show and generics in BiocGenerics (and soon ProtGenerics, hopefully) are clear cases where the name is generic used in multiple packages for different classes. But others like proteotypic, calculateHeavyLabels, proteinCoverage probably not, and probably result in more complexity that necessary. I plan to change such cases to function.

lgatto commented 9 years ago

See commits 2842be7602cd1695dbdf16ae2b0cc9f218588edf and 6aeca639b46af10886ce820321c64a3673118b90. I will check if there are other candidates and updated accordingly.