plotOutput is called with deprecated clickId parameter

lgatto / RforProteomics

Using R and Bioconductor packages for the analysis and comprehension of proteomics data.

http://lgatto.github.io/RforProteomics

83 stars 33 forks source link

plotOutput is called with deprecated clickId parameter #13

Closed wch closed 3 years ago

wch commented 4 years ago

When running a reverse dependency check on the development version of Shiny, which we are about to release, we see:

✖ RforProteomics 1.26.0                  ── E: 0     | W: 1     | N: 2  +1                                                                                                     
  * checking R code for possible problems ... NOTE

    shinyMA: possible error in plotOutput("plotma", clickId =
      "plotma_click", width = 400, height = 400): unused argument (clickId
      = "plotma_click")

The clickId parameter was deprecated 5 years ago, and we recently removed it. https://github.com/rstudio/shiny/pull/2834

lgatto commented 3 years ago

This has finally been fixed. Thank you and sorry for the delay.