search

lgatto / pRoloc

A unifying bioinformatics framework for organelle proteomics
http://lgatto.github.io/pRoloc/
15 stars 13 forks source link

Cholesky decomposition fix #124

Closed lgatto closed 5 years ago

lgatto commented 5 years ago

@ococrook - I saw the cholesky-fix branch. Thank you.

Do you think this warrants a warning, or would a simple message not suffice. Also, whether it's a message or warning, could you refer the user to the documentation, and add a paragraph with a bit of explanation.

ococrook commented 5 years ago

Yes, a message is probably sufficient. Should I replace warning(...) with message(...)?

When you refer to documentation - do you mean the rd file or the vingette (or Both)?

lgatto commented 5 years ago

Yes, use message().

Re documentation, the rd file is enough, especially as users will be directed to it when the fix kicks in.

ococrook commented 5 years ago

great, pull request made!

lgatto commented 5 years ago

Closing, as PR #125 has been merged.