Control grid presence in plot2D

lgatto / pRoloc

A unifying bioinformatics framework for organelle proteomics

http://lgatto.github.io/pRoloc/

15 stars 13 forks source link

Control grid presence in plot2D #128

Closed lgatto closed 5 years ago

lgatto commented 5 years ago

As per popular demand, provide an option to not add the grid in plot2D.

plot2D(..., grid = TRUE)
plot2D(..., grid = FALSE)

If this is indeed the preferred way, one could also complete drop it, and call grid() manually after plot2D

plot2D(...)
grid()

cc @lmsimp

lmsimp commented 5 years ago

@ococrook :-)

lgatto commented 5 years ago

Please cast your vote for either

grid argument with default value TRUE (thumbs up this comment :+1: )
no grid at all (thumb down this comment :-1:)

I don't see the point of having a grid = FALSE default, as typing grid = TRUE as parameter in plot2D is longer than typing grid() after the function.

lmsimp commented 5 years ago

The default should still be grid = TRUE as per https://github.com/lgatto/pRoloc/pull/129. That is indeed my preference