search

lgatto / pRoloc

A unifying bioinformatics framework for organelle proteomics
http://lgatto.github.io/pRoloc/
15 stars 14 forks source link

pRolocVisMethods #61

Closed lmsimp closed 9 years ago

lmsimp commented 9 years ago
lmsimp commented 9 years ago

@lgatto Have added pRolocVisMethod and .validpRolocVisMethod to plotting.R I will now add this check to my new vis functions and plot2D.

Kept this all in the 'threshold-functions' branch for now.

lmsimp commented 9 years ago

@lgatto Just seen you already have plot2Dmethods I think pRolocVisMethod is better as its more general.

Do you think scree should be a method? For the vis apps if scree is selected do you think I should by default plot the first two PCs? Or not allow scree as and plotting method for the Shiny Apps?

lgatto commented 9 years ago

Just seen you already have plot2Dmethods I think pRolocVisMethod is better as its more general

plot2Dmethods <- c(plotVisMethods, "scree")

and keep both.

lmsimp commented 9 years ago

Great idea. Will do this.