lgatto / pRolocGUI

Interactive visualisation and exploration of spatial proteomics data
http://lgatto.github.io/pRolocGUI
7 stars 5 forks source link

PCA and saved searches #16

Closed lgatto closed 10 years ago

lgatto commented 10 years ago

It is not possible to create 'new' saved searches while previous ones are displayed on the PCA plot. This leads to new FoIs to include the new selected features and the previously created sets.

1) Display saved search A (with proteins a1, a2, a3) and B (with proteins b1 and b2) 2) On the PCA, select other features, say x and y. 3) In the search tab, create a new FoI, which will contain 7 proteins: x, y and a1, a2, a3, b1, b2.

tnaake commented 10 years ago

If you do not want to include the proteins a1, a2, a3, b1, b2 in the new FoI which contains only x, y) deselect saved searches in Display selection. I think, it is useful to keep the existing functionality in case we want to include an "old" FoI into a "new" one.

lgatto commented 10 years ago

Yes, but the way the 'Display selection' should be independent - at least they can be displayed independently. If I select features to be saved, I would have expected that only those related to the PCA select would be considered for the new saved search. Do you see my point? Anyway, this is not a priority for not and is probably partly a matter of taste.

tnaake commented 10 years ago

I agree that it is a matter of taste. For me, the "Display selection" has a very important function in the shiny apps for they control the selected features on the plots and the output on the meta-data tabs. As they do this, it seemed obvious to me that by controlling the "Display selection" one can also save features; this also allows to save features which come from different input (click input from PCA plot or protein profile plot or from query).