Kohze commented 6 years ago

Wanted to share my current first version of SpatialMaps. One of the points we discussed is renaming the function to something like SM_... or similar instead of just login(), download() and so on (where we yet have to find a fitting convention).

Tomorrow I will complete the unit test implementation and write a general overview of the functions and how they interplay with each other.

codecov-io commented 6 years ago

Codecov Report

Merging #27 into master will decrease coverage by 22.45%. The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #27       +/-   ##
==========================================
- Coverage   26.08%   3.63%   -22.46%     
==========================================
  Files           2       2               
  Lines          23     165      +142     
==========================================
  Hits            6       6               
- Misses         17     159      +142

Impacted Files	Coverage Δ
R/data.R	`1.24% <0%> (-9.29%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d1865c6...b4f8e4c. Read the comment docs.

lgatto commented 6 years ago

Not sure why you closed this PR, as it wasn't merged yet. Is it not relevant anymore? Do you plan to submit a new one?

Kohze commented 6 years ago

The new PR is more advanced and solved many issues, so I deleted that one (will request a new PR once i got one last issue solved).

lgatto commented 6 years ago

Ok, thanks

lgatto / pRolocdata

First alpha version: pRolocdata connected to the SpatialMaps DB: #27

Codecov Report