Add Shin et al data Nat. Comm 2020

lgatto / pRolocdata

Data accompanying the pRoloc package

5 stars 5 forks source link

Closed ococrook closed 4 years ago

ococrook commented 4 years ago

add dynamic mitoretargetting data from Shin et al

ococrook commented 4 years ago

checks and build locally with Error. Markfile warnings only

lgatto commented 4 years ago

I have also deleted the .Rhistory files.

ococrook commented 4 years ago

I'll have to hunt down the .csv files, since they weren't generate in the CCP.

lgatto commented 4 years ago

Oh, that's very annoying. Are there any SI spreadsheets with the paper?

ococrook commented 4 years ago

I'll send some emails too see if I get the .csv, since that's probably preferable?

lgatto commented 4 years ago

It would be better rather than the binary files, as it is possible to trace back to something that was published. If not possible, than never mind.

ococrook commented 4 years ago

now using raw .csv files. No build problems locally

lgatto commented 4 years ago

Thanks for the PR - next time there will be 2 additional things to do

Bump the version (check first on here to make sure you bump z by 1) and update the NEWS file.
Update the README.md file be re-knitting README.Rmd

lgatto commented 4 years ago

Also pushed to Bioc (devel). Will become available in a couple of days.

ococrook commented 4 years ago

When do these things need to be changed?

lgatto commented 4 years ago

Every time the package is changed, and ready to be released.

There can of course be multiple changes/entries in the NEWS file for a single version bump.