search

lgatto / synapter

Label-free data analysis pipeline for optimal identification and quantitation
https://lgatto.github.io/synapter/
4 stars 2 forks source link

bug in filterNonUniqueMatches #114

Closed pavel-shliaha closed 8 years ago

pavel-shliaha commented 8 years ago

the files and code are in: synapter2paper\bugs

filterNonUniqueMatches(synapterAnalysis, minDelta = nonUniqueThreshold) Error in [<-.data.frame(*tmp*, rows[keep], cols, value = list(precursor.leID.quant = c(7620, : missing values are not allowed in subscripted assignments of data frames

sgibb commented 8 years ago

JFTR: the reason for the bug was in the .fragmentMatchingDifferences function (but hits the filterNonUniqueMatches function) that looks for non-unique-true and non-unique-false matches but ignores the newly introduced no-quant-id result (which could contain multiple matches, too). Now we treat all matches with more than 1 match as non-unique onces.