search

lgatto / synapter

Label-free data analysis pipeline for optimal identification and quantitation
https://lgatto.github.io/synapter/
4 stars 2 forks source link

increase class version to 2.0 and regenerate data/synapterTiny.rda #122

Closed sgibb closed 7 years ago

sgibb commented 7 years ago

I already did this by updateObject(synpaterTiny); save(synapterTiny, file="inst/synapterTiny.rda", compress="xz") in https://github.com/lgatto/synapter/commit/d004917a67765a9edf2befa249beaeb70ae2a1f8 but I would prefer to create the dataset from scratch. Hopefully updateObject works correctly but I don't want to rely on this. @lgatto could you recreate the synapterTiny object? The data should be at: /home/lgatto/Data/Synapt/test_data_08_reduced_dataset/reduced/

sgibb commented 7 years ago

Just FYI the class version is 2.0.0 since https://github.com/lgatto/synapter/commit/e0d5f9c04449fdeeaae5b13f639313ee7e2c7dd3

sgibb commented 7 years ago

@lgatto:

I can't find any underlying data for synapterTiny. As far as I can remember, it evolved from repreated organic cutting and hacking until it got small enough and still useful. In both cases about, we need an updateObject method (see for example here [1]) to be applied on any existing object. Having said that, I haven't done (nor seen) this for references classes yet. [1] https://github.com/lgatto/MSnbase/blob/master/R/methods-updateObjectTo.R

As stated above there is already an updateObject method for Synapter objects. If you can't found the data at /home/lgatto/Data/Synapt/test_data_08_reduced_dataset/reduced/ I will close this issue and hope that updateObject works correctly.