search

lgblgblgb / xemu

Emulations (running on Linux/Unix/Windows/macOS, utilizing SDL2) of some - mainly - 8 bit machines, including the Commodore LCD, Commodore 65, and the MEGA65 as well.
https://github.com/lgblgblgb/xemu/wiki
GNU General Public License v2.0
208 stars 32 forks source link

rom: Fix documentation regarding how to fetch roms #298

Closed ricardoquesada closed 3 years ago

ricardoquesada commented 3 years ago

Replace make roms with make fetchroms

lgblgblgb commented 3 years ago

Thanks for the PR, but unfortunately it's not correct. As the documentation states:

make roms
(issued from the root directory of the project)

Now, if you modify make roms to make fetchroms it's invalid, as no fetchroms in the Makefile in the root directory of the project, so documentation makes no sense from that point. What you suggest is only valid if the comment after that make line is also altered that the make fetchroms command should be issued after entering the directory named rom or suggestion to issue make -C rom fetchroms would be valid if the "(issued from the root directory of the project)" remains as well, unmodified.

Also the second, not so technical kind of issues here: as far as I can see, Xemu is mainly used by people because of its MEGA65 emulator, and it's much more rare to show interest for the other emulators. However for MEGA65 (and btw for C65 emulator as well) it has become a sensitive legal issue about the legal status of the C65 ROM since C65/MEGA65 went a quite hot topic recently after a relative silence since decades. Thus it does not even make too much sense to suggest this make command any more as it does not bring any value for 99.99% of people, want to use Xemu for MEGA65 emulation, being happy to see they can fetch roms, then being disappointed (or even getting angry) that still no C65 ROM, which is intentional unfortunately, as the legal status of the ROM does not allow this. Indeed, I had the mistake not much take attention about this, so in older versions of the Xemu repository, this worked actually, but I had to remove it ...

Honestly, I would rather remove any reference for any kind of fetchroms stuff from the documentation to avoid confusion of people.

And thirdly, I don't accept any PR to master, master branch itself only be updated via next, next being the "staging" branch to collect changes become master periodically.

Please note that I do value your effort, it's not that I don't. The bulk of the issue here that this whole "getting the ROM" automatically or with help of make is legally problematic ...

lgblgblgb commented 3 years ago

Since not so much an answer, allow me to close this, since the PR itself (which again, I thank for your work and effort) is problematic as it's not true even with the modification what the documentation would state then. I would rather exclude the make roms stuff and similar mentions, since it's no more valid too much for anybody unless an Xemu developer (in that case, generic documentation does not help too much anyway!). Thanks again!

ricardoquesada commented 3 years ago

thanks for the detailed answer!... I know that trademark/copyright/IP issues could be problematic