search

lgc-4 / one.com-ddns-python-script

A (relatively) simple python script to update one.com type A DNS records
GNU General Public License v3.0
20 stars 6 forks source link

docker support? #5

Open sim0nsen opened 2 years ago

sim0nsen commented 2 years ago

Hi, Really like your script, did some modifications to it, to support loading variables from environment settings. I have a version that is docker compatible. Would that be of interest as a feature?

lgc-4 commented 2 years ago

Hi, sorry I hadn't checked github in a while. I've never personally used docker but making the script docker compatible definitely sounds like a great idea. Mind creating a Pull Request so I can look into it?

sim0nsen commented 2 years ago

Yeah no problem ;) Im new to GitHub so might need some guidance? I’ve cloned the repo, made my changes in a feature branch. So do I create a pr from my branch to master, directly from my git client? I tried pushing my branch, but that was not allowed ;)

lgc-4 commented 2 years ago

I think you have to create a Fork of my Repo on your GitHub, create a feature branch on there and then make the pr Maybe this helps

sim0nsen commented 2 years ago

Thx, will look into it