search

lgeiger / hydrogen-launcher

:rocket: Launch terminals and jupyter consoles connected to hydrogen
https://atom.io/packages/hydrogen-launcher
MIT License
96 stars 25 forks source link

Object.dirname is deprecated. #24

Open eacabbi opened 7 years ago

eacabbi commented 7 years ago

Argument to path.dirname must be a string

Object.dirname (/Applications/Atom.app/Contents/Resources/app/src/electron-shims.js:9:10)
Object.getCWD (/Users/eacabbi/.atom/packages/hydrogen-launcher/lib/main.js:178:103)
Object.launchTerminal (/Users/eacabbi/.atom/packages/hydrogen-launcher/lib/main.js:99:56)
HTMLElement.hydrogenLauncherLaunchTerminal (/Users/eacabbi/.atom/packages/hydrogen-launcher/lib/main.js:52:22)
CommandRegistry.handleCommandEvent (<embedded>:22091:35)
<unknown> (<embedded>:21829:65)
idblr commented 5 years ago

Same issue. Unable to open "Hydrogen Launcher: Launch Jupyter Console in Platformio Terminal" in Atom 1.38.2 x64 using hydrogen-launcher package version 1.2.2 accompanied by platformio-ide-terminal package version 2.9.1. I receive the following error: "Could not find Jupyter or iphyton"

Related to #23, perhaps?

I can launch "Platformio Ide Terminal" and "Hydrogen Launcher: Launch Terminal" but not "Hydrogen Launcher: Launch Jupyter Console" so doesn't seem like an issue with platformio-ide-terminal