Implement data storage and Adjust Past Records

lgerhardt45 / Jointify

Digitalizing ROM analysis for the MRI hospital, Munich, as part of the Tech Challenge

5 stars 0 forks source link

Implement data storage and Adjust Past Records #55

Closed annalena94 closed 4 years ago

annalena94 commented 4 years ago

implementation of a DataHandler enum which offers methods to read and write JSON files which are then stored or retrieved from the DocumentDirectory of the phone
made measurement class and structs of its variables codable for JSON compability
added DateFormat extension to allow for proper display of dates
adjusted the past records on the welcome view to show the first frame of the measurement, the date and the corrsponding values

lgerhardt45 commented 4 years ago

Looks very smart, thanks a lot! IMO (in my opinion) the text on the list view needs to be left aligned and to use ints rather than Doubles.

All other adjustments can be made in another issue :-)

Also, there are some conflicts.

lgerhardt45 commented 4 years ago

I fixed the conflicts

BergmuellerNiklas commented 4 years ago

Thanks for this! Like it a lot :)

Just make sure to check my comment about the maximum length of the list.

lgerhardt45 commented 4 years ago

Good Job, I like it. Especially the small UIImage Previie of the Recording.

Just one small formatting issue, the lines now collide with the right edge of the screen and the scroll bar, but as Lukas said: This can be fixed in another issue.

This looks like an easy issue (padding: .horizontal?). Please fix in this PR.

lgerhardt45 commented 4 years ago

@annalena94 did you finish implementing the changes? Please attach the changed screenshots if so.

lgerhardt45 commented 4 years ago

I removed the conflicts with develop ☺️