search

lgerhardt45 / Jointify

Digitalizing ROM analysis for the MRI hospital, Munich, as part of the Tech Challenge
5 stars 0 forks source link

Quickfix: prevent adding non-successful measurements. #76

Closed BergmuellerNiklas closed 4 years ago

BergmuellerNiklas commented 4 years ago

This is a quickfix for a problem we briefly discussed yesterday. The logic is build upon the logic from yesterday's PR. Let me know if you have any doubts about this solution.

lgerhardt45 commented 4 years ago

I would rather like to see https://github.com/lgerhardt45/Jointify/issues/36 implemented properly as this is an issue we set for this week rather than chucking a quickfix in. I don‘t have a chance to check to fix properly until tonight but let’s talk then.

BergmuellerNiklas commented 4 years ago

I would rather like to see #36 implemented properly as this is an issue we set for this week rather than chucking a quickfix in. I don‘t have a chance to check to fix properly until tonight but let’s talk then.

Yes working on this one as well! Will add a second PR for this tomorrow probably. Just need to ask you some front end related questions :D