search

lgi-devs / lgi

Dynamic Lua binding to GObject libraries using GObject-Introspection
MIT License
440 stars 70 forks source link

Progress callback #296

Closed ntd closed 2 years ago

ntd commented 2 years ago

This touches a quite delicate part of LGI, so it probably requires much more eyeballs than only mine.

pavouk commented 2 years ago

LGTM. Thanks!

psychon commented 2 years ago

You got a "LGTM" from pavouk, produced a PR with nice, small, self-contained commits, you are touching code that I do not understand. I want you on the team!

Merging based on the "LGTM" from someone who definitely knows this stuff and since this seems like you know what you are doing. Thanks a lot!

ntd commented 2 years ago

... I want you on the team!

Thank you: lately I'm using LGI sparingly but I would be happy to help where I can. Not sure what to do though...

Merging based on the "LGTM" from someone who definitely knows this stuff and since this seems like you know what you are doing.

"seems" is the keyword here :smile:

I did not grasp that much: I just got the intent of the internal flag from the comments and checked this was not reflected by the code. Kudos to @pavouk for his comments: they are really helpful.