search

lgirdk / boardfarm-docsis

5 stars 1 forks source link

The function "check_valid_docsis_ip_networking" in "docsis_lib/docsis.py" seems to have some problems #2

Closed mbanders closed 5 years ago

mbanders commented 5 years ago

Around this section here https://github.com/lgirdk/boardfarm-docsis/blob/master/tests/docsis_lib/docsis.py#L256-L279

The functions valid_ipv6 and valid_ipv4 return only True or False and they hide exceptions. But nothing is getting the return values of these functions so effectively those lines of code don't do anything.

It appears the goal was for those functions to raise Exceptions that could then be caught.

mbanders commented 5 years ago

This perhaps was fixed with https://github.com/lgirdk/boardfarm/commit/28901d6fe2310887170db2d5bf3c5f42d1fd28bb