search

lgirdk / boardfarm

Automated testing with python
BSD 3-Clause Clear License
21 stars 33 forks source link

tests: lib: docsis: added method to check CM is in briged mode #263

Closed premandfriends closed 5 years ago

premandfriends commented 5 years ago 
-Under cm_cfg class added method "_is_bridged" to check whether CM is in bridge mode

Signed-off-by: prekumar.contractor prekumar.contractor@libertyglobal.com

This change is Reviewable

mattsm commented 5 years ago

@preddy-contractor is this enough to confirm if we are in bridged mode?

mattsm commented 5 years ago

Thanks Preddy- what is the default behavior if none are present?

preddy-contractor commented 5 years ago

Bridge Mode if none is presented.

mattsm commented 5 years ago

Thanks, @premandfriends can fix the one case at least where eRouter is present and it would be in bridged mode? Thanks.

premandfriends commented 5 years ago

Working on the changes. Hoping to update the commit before 29th March

mattsm commented 5 years ago

@premandfriends ping... this should be an easy cleanup no?

premandfriends commented 5 years ago

This function is enhanced to check all config modes. https://github.com/lgirdk/boardfarm/pull/287

mattsm commented 5 years ago

hmm this doesn't look merged, why did it get closed?

premandfriends commented 5 years ago

Hi Matthew The function to check the CM config mode based on Prasada's input is implemented in https://github.com/lgirdk/boardfarm/pull/287 . As the function has become generic and as this thread is related to only bridge, i have closed this thread