search

lgirdk / boardfarm

Automated testing with python
BSD 3-Clause Clear License
21 stars 33 forks source link

pyflake issues in tests/lib directory #335

Closed mbanders closed 5 years ago

mbanders commented 5 years ago

Issues found by pyflakes:

tests/lib$ pyflakes *.py
common.py:19: 'from selenium.webdriver.common.proxy import *' used; unable to detect undefined names
common.py:45: 'self' may be undefined, or defined from star imports: selenium.webdriver.common.proxy
common.py:168: 'proxy' may be undefined, or defined from star imports: selenium.webdriver.common.proxy
common.py:452: local variable 'escaped_oid' is assigned to but never used
docsis.py:227: undefined name 'valid_ipv4'
docsis.py:229: undefined name 'valid_ipv6'
docsis.py:233: undefined name 'valid_ipv4'
docsis.py:235: undefined name 'valid_ipv6'
docsis.py:239: undefined name 'valid_ipv4'
docsis.py:241: undefined name 'valid_ipv6'
__init__.py:8: 'common' imported but unused
network_helper.py:9: 'from netaddr import *' used; unable to detect undefined names
network_helper.py:15: 'EUI' may be undefined, or defined from star imports: netaddr
network_helper.py:15: 'mac_unix' may be undefined, or defined from star imports: netaddr
SnmpHelper.py:10: 're' imported but unused
SnmpHelper.py:20: 'logging' imported but unused
SnmpHelper.py:74: local variable 'results' is assigned to but never used
SnmpHelper.py:121: undefined name 'SnmpMibsUnitTest'
SnmpHelper.py:129: undefined name 'SnmpMibsUnitTest'
streamboost.py:250: local variable 'e' is assigned to but never used
mattsm commented 5 years ago

valid_ipv{4,6} in docsis.py seems like a major error...

can probably remote the last file

mbanders commented 5 years ago

Alright I think this is as resolved as it can be for now.

tests/lib$ pyflakes *.py
__init__.py:8: 'common' imported but unused

That "common" is actually used by the tests. Not sure how pyflakes would know that though.