search

lgrignon / jsweet-gradle-plugin

Brings the power of JSweet to Gradle
Apache License 2.0
17 stars 15 forks source link

Minor feedback on what tasks depend on what #15

Closed nedtwigg closed 6 years ago

nedtwigg commented 6 years ago

Minor feedback on this snippet.

1: It would be better to depend on compileJava rather than classes:

2: It's easier to compose tasks in custom plugins if the tasks don't automatically create dependencies. Probably the JSweetPlugin should add the dependency, rather than the task constructor.

lgrignon commented 6 years ago

Thanks for the feedback. Would you create a PR for this? I would merge it ASAP