search

lgrignon / jsweet-gradle-plugin

Brings the power of JSweet to Gradle
Apache License 2.0
17 stars 15 forks source link

Should define its own sourceSet #22

Closed vorth closed 3 years ago

vorth commented 3 years ago

The plugin should define its own "jsweet" sourceSet, and only fall back to "main" if "jsweet" is absent. In addition, the includes and excludes should be handled in the standard sourceSet fashion, not as configs of the JSweet plugin.

My use-case is a little odd: I'm building both a legacy Java project, and a JSweet-enabled web port, from the same sources. This is effectively impossible without giving the two Gradle plugins different ways to select their sources from the same files.

lgrignon commented 3 years ago

Thanks @vorth This is indeed a good idea. Not sure if we have enough time to change this though, but will definitely try to do it!

vorth commented 3 years ago

I have made the change in a fork, but I did it on the 3.0 branch, which meant I had to switch from Java 8 to Java 11. I’ll make it on the master, and submit a PR.

On 2020/09/08, at 08:27, Louis Grignon notifications@github.com wrote:

Thanks @vorth This is indeed a good idea. Not sure if we have enough time to change this though, but will definitely try to do it!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

lgrignon commented 3 years ago

That's good news. Actually you can PR to 3.0 branch which is about to be released soon. I will publish 3.0.0-RC4 version of the gradle plugin once your PR is merged

lgrignon commented 3 years ago

will be deployed with 2.4 and 3.0